feat: promoted keys in properties table #25891
Conversation
| * The container for these properties e.g. the event name of the event the properties are on | ||
| * Can be used for e.g. to promote particular properties when sorting the properties | ||
| */ | ||
| parent?: string |
There was a problem hiding this comment.
it now needs to know its context so it can detect what properties can be promoted
i couldn't think of a better name than parent but I'm open to suggestions
There was a problem hiding this comment.
parentEvent could work, as this is an event? At least it's a bit more descriptive
There was a problem hiding this comment.
it could be other things in future... e.g. groups have properties
i played with container, context, parent
i guess it's easy to change and as we add things it might become clear what it should be called
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
frontend/src/lib/components/PropertiesTable/PropertiesTable.tsx
Outdated
Show resolved
Hide resolved
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: Richard Borcsik <[email protected]>
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
in the replay inspector we promote properties on known events to the top of the sorting order so they're easier to find
this copies that user affordance to the properties table
e.g. promoting url on page view even though the list is sorted alphabetically otherwise