Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: trials UI on teams #25885

Merged
merged 17 commits into from
Nov 1, 2024
Merged

feat: trials UI on teams #25885

merged 17 commits into from
Nov 1, 2024

Conversation

zlwaterfield
Copy link
Contributor

@zlwaterfield zlwaterfield commented Oct 29, 2024

Changes

Integrating the new trials functionality for teams add-on.

Billing PR: https://github.com/PostHog/billing/pull/964

Details

  • You can only add a trial for teams
  • It will be 14 days
  • You can only have one active trial at a time
  • You can only add a trial if you are already on the paid plan (to reduce complexity)
  • Will auto convert and charge after 14 days
  • If you activate a trial and then cancel you can't reactive the trial
  • You will be emails 3 days before trial ends and when trial ends
  • A/B test for the trial method (modal or direct)

Future

  • cancel trial - need to figure out how to stop re-adding trial first
  • extend trial

Screenshots:

Screenshot 2024-10-31 at 11 42 50 AM Screenshot 2024-10-31 at 12 54 26 PM Screenshot 2024-10-31 at 12 54 07 PM Screenshot 2024-10-31 at 12 54 04 PM Screenshot 2024-10-31 at 12 54 30 PM

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@zlwaterfield zlwaterfield self-assigned this Oct 29, 2024
Copy link
Contributor

github-actions bot commented Oct 29, 2024

Size Change: +40 B (0%)

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.15 MB +40 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

8 snapshot changes in total. 0 added, 8 modified, 0 deleted:

  • chromium: 0 added, 8 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@zlwaterfield zlwaterfield marked this pull request as ready for review October 31, 2024 16:55
Comment on lines +193 to +202
{/* Comment out until we can make sure a customer can't activate a trial multiple times */}
{/* <LemonButton
type="primary"
size="small"
onClick={cancelTrial}
loading={trialLoading}
className="mt-1"
>
Cancel trial
</LemonButton> */}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we at least give them a button to contact support to cancel?

Or just make sure people can't activate trial multiple times in the next couple of days.. it would be very weird to not have any way to cancel, after we say they can cancel it at any time

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's more of mental block tbh, I just want to get this out and I'll think through cancel tomorrow.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

  • chromium: 0 added, 6 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@zlwaterfield zlwaterfield merged commit 003ac8a into master Nov 1, 2024
96 checks passed
@zlwaterfield zlwaterfield deleted the zach/teams-trial-ui branch November 1, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants