Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(data-warehouse): Upgraded temporal UI image #25882

Merged
merged 1 commit into from
Oct 30, 2024
Merged

chore(data-warehouse): Upgraded temporal UI image #25882

merged 1 commit into from
Oct 30, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • When using the Temporal UI locally, we can't perform any admin tasks - every network request gets returned with an error. This is cause the csrf token cookie is a HTTPS cookie and the UI is served over HTTP

Changes

  • Newer versions of temporalio/ui takes an env var to serve the csrf cookie over HTTP, allowing us to be. able to cancel/delete workflows etc from the UI directly 🥳
    • Updates the UI image the latest build
    • Adds the insecure csrf env var

@Gilbert09 Gilbert09 requested review from tomasfarias and a team October 29, 2024 18:11
@Gilbert09 Gilbert09 merged commit bc11915 into master Oct 30, 2024
89 checks passed
@Gilbert09 Gilbert09 deleted the tom/temporal-ui-docker branch October 30, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasfarias tomasfarias tomasfarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @tomasfarias