-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Split Temporal backend suite into three #25880
Conversation
Looks like this didn't have as much of an effect, because the run time is heavily skewed towards a few tests. Group 3 still takes 20 minutes. These tests are the biggest offenders, each taking over 60 seconds:
|
0705285
to
f2e005c
Compare
ddb69c6
to
299da94
Compare
This comment was marked as outdated.
This comment was marked as outdated.
24aaa05
to
b18cefc
Compare
fdf11ac
to
f0e3e8c
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
@Twixes I didn't care too much about the Edit: Looks like |
this is a good way to do it (vs running locally which can be annoying) -> https://github.com/PostHog/posthog/blob/master/.github/workflows/ci-backend-update-test-timing.yml#L43 -> https://github.com/PostHog/posthog/actions/workflows/ci-backend-update-test-timing.yml although iirc last time temporal failed for some reason, which is why I split them out in the first place. I think if you just try running temporal tests, might work here. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
@neilkakkar, yup, already updated .test_durations in |
ah missed that commit, perfect 👍 |
Problem
The Temporal suite is taking around 25 minutes to complete (example, not an unusual one). A 25 minute wait kills productivity.
Changes
Splitting the suite into three groups.