Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Surveys): Allow Personal API Keys to read responses_count for surveys #25879

Merged
merged 10 commits into from
Oct 29, 2024

Conversation

Phanatic
Copy link
Contributor

Problem

This PR fixes the api endpoint for responses_count to accept a person API token with the survey:read scope.
Reported by a user on zendesk

Changes

Add the required_scopes attribute to the method decorator on the responses_count API method.

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Automated tests.

@Phanatic Phanatic enabled auto-merge (squash) October 29, 2024 17:03
Copy link
Contributor

@dmarticus dmarticus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, nice fix!

@Phanatic Phanatic merged commit 13f48d7 into master Oct 29, 2024
86 checks passed
@Phanatic Phanatic deleted the survey-responses-count branch October 29, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants