-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Experiments): Allow users to edit and preview no-code experiments from experiment page. #25877
Conversation
4082893
to
6881ac4
Compare
Not sure if this is still on a todo list, but transforms for a variant still isn't applied correctly here: Screen.Recording.2024-10-29.at.17.06.46.mov |
When saving a new experiment, an empty error banner flickers before successfully saving: Screen.Recording.2024-10-29.at.17.11.06.mov |
frontend/src/scenes/experiments/WebExperimentImplementationDetails.tsx
Outdated
Show resolved
Hide resolved
Working well, some comments :) |
@jurajmajerik thanks for taking a look! re : #25877 (comment) The transform the HTML is overriding the transform for the text. Maybe I should order it so that the most significant changes happen first and then the lower priority. As an example HTML Changes -> CSS changes -> Text changes. This way, the Text changes are always applied. This should be fixed now |
…ails.tsx Co-authored-by: Juraj Majerik <[email protected]>
Good catch on #25877 (comment) |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
b70a767
to
b4dbb4d
Compare
Size Change: +613 B (+0.05%) Total Size: 1.15 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
In the past, creating a no-code experiment required a user to navigate to the
Toolbar
page and then launch the toolbar from there to edit an existing experiment.This PR instead adds a custom
implementation
section to the experiment page that allows a user to bring up the toolbar with the experiment pre-selected. It also adds apreview variant
button to each variant of the web experiment.Changes
1. Editing a web experiment from its individual page.
On the edit page of a web experiment, this is what you see now for
implementation
Clicking on
Edit Web experiment on website
brings up this dialog that shows the authorized URLs for the posthog projectSelecting a URL takes one to the domain with the experiment pre-selected
2. Previewing web experiment variants from an experiment page.
The Distribution table now has an additional column if its a web experiment, all widths adjusted accordingly.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?