Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): add option to run a hog function per person per event #25874

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

MarconLP
Copy link
Member

Problem

The only option to get notified per event is to duplicate the hog function multiple times.
https://posthoghelp.zendesk.com/agent/tickets/19696

Changes

  • adds an option to trigger functions once per person per event per interval

How did you test this code?

updated tests

@MarconLP MarconLP requested a review from a team October 29, 2024 15:20
Copy link
Contributor

Size Change: 0 B

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.15 MB

compressed-size-action

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Just for awareness we have to be careful with these. The masks are all stored in redis so the higher the cardinality, the higher the DB usage is and at some point it could become a bottleneck. But event name is relatively safe 👍

@MarconLP MarconLP merged commit 78ea7fb into master Oct 30, 2024
94 checks passed
@MarconLP MarconLP deleted the per-event-per-person branch October 30, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants