Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cdp): remove double indicator #25853

Merged
merged 1 commit into from
Oct 28, 2024
Merged

fix(cdp): remove double indicator #25853

merged 1 commit into from
Oct 28, 2024

Conversation

MarconLP
Copy link
Member

Problem

We were showing the hog function status indicator twice
2024-10-28 at 15 44 35

Changes

  • only show the status indicator when showEnabled is true.

@MarconLP MarconLP requested a review from oliverb123 October 28, 2024 14:45
@github-actions GitHub Actions
Copy link
Contributor

Size Change: 0 B

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.15 MB

compressed-size-action

@MarconLP MarconLP merged commit 6914fc7 into master Oct 28, 2024
95 checks passed
@MarconLP MarconLP deleted the remove-double-indicator branch October 28, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverb123 oliverb123 oliverb123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarconLP @oliverb123