Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(experiments HogQL): render main goal from HogQL #25852

Merged
merged 78 commits into from
Oct 30, 2024

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Oct 28, 2024

Changes

Feature flag: experiments-hogql

Render results for the main experiment goal using the HogQL query.

Used a few type casts to satisfy the compiler. Will clean up and re-type properly once the flag is removed.

Old query HogQL query
image image

How did you test this code?

👀

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Size Change: +38 B (0%)

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.15 MB +38 B (0%)

compressed-size-action

@jurajmajerik jurajmajerik changed the title chore(experiments HogQL): update UI chore(experiments HogQL): render main goal from HogQL Oct 28, 2024
@jurajmajerik jurajmajerik marked this pull request as ready for review October 28, 2024 15:42
@jurajmajerik jurajmajerik requested a review from timgl October 28, 2024 15:43
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@jurajmajerik jurajmajerik merged commit 019d4dc into master Oct 30, 2024
90 of 92 checks passed
@jurajmajerik jurajmajerik deleted the experiments-hogql-ui branch October 30, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants