Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(replay): add url blocklist #25845

Merged
merged 18 commits into from
Oct 29, 2024
Merged

feat(replay): add url blocklist #25845

merged 18 commits into from
Oct 29, 2024

Conversation

richard-better
Copy link
Contributor

@richard-better richard-better commented Oct 28, 2024

Problem

We want to pause recordings on certain pages, to make sure they're not recorded. Examples could be Admin panels, or non-interesting pages.

Changes

image
  • Moved session recording ingest controls to new file
  • Added controls for blocklist, reusing same components

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

github-actions bot commented Oct 28, 2024

Size Change: +60 B (+0.01%)

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.15 MB +60 B (+0.01%)

compressed-size-action

@richard-better richard-better requested review from pauldambra and a team October 28, 2024 13:44
@richard-better richard-better marked this pull request as ready for review October 28, 2024 13:44
Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@richard-better richard-better merged commit 318a894 into master Oct 29, 2024
94 checks passed
@richard-better richard-better deleted the richard/blocklist branch October 29, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants