Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(messaging): different types of hog functions #25788

Merged
merged 26 commits into from
Oct 25, 2024
Merged

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Oct 24, 2024

Problem

Splitting up #25719

Changes

  • PR 1 - migration and backend split
    • Migration to add type to the HogFunction model. Type will be set to destination for all existing functions.
    • The plugin server only runs destination functions on events, but also loads email functions (shared provider code) into memory.
    • The backend returns hog functions based on type, and the frontend only asks for destination
    • Tests for all of the above

How did you test this code?

  • Added tests to make sure we can list with a type filter
  • Added tests to make sure the plugin server only looks at destinations
  • Updated existing tests to use the new type field
  • Clicked around the interface and I could still edit/create/update existing destinations as before

Copy link
Contributor

github-actions bot commented Oct 24, 2024

Size Change: +36 B (0%)

Total Size: 1.15 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.15 MB +36 B (0%)

compressed-size-action

@PostHog PostHog deleted a comment from posthog-bot Oct 24, 2024
@PostHog PostHog deleted a comment from posthog-bot Oct 24, 2024
@mariusandra mariusandra marked this pull request as ready for review October 24, 2024 13:09
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

  • chromium: 0 added, 1 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

  • chromium: 0 added, 3 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

4 snapshot changes in total. 0 added, 4 modified, 0 deleted:

  • chromium: 0 added, 4 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@mariusandra mariusandra requested review from oliverb123, MarconLP and a team October 25, 2024 07:04
@mariusandra mariusandra merged commit e72783b into master Oct 25, 2024
94 checks passed
@mariusandra mariusandra deleted the messaging-part-1 branch October 25, 2024 09:20
timgl pushed a commit that referenced this pull request Oct 25, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
@mariusandra mariusandra mentioned this pull request Oct 25, 2024
42 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants