fix(experiments): show variant overrides in the sidebar view #25777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
jurajmajerik
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cory pointed out that the optional variant overrides didn't display on the sidebar: https://posthog.slack.com/archives/C07Q2U4BH4L/p1729713502712939
Changes
Made it so that we can pass in an optional set of variants to the
FeatureFlagReleaseConditionsinstead of having that component manage all of thenonEmptyVariantsNew behavior: https://www.loom.com/share/a4c61ab56bb84a0697b8f2145821241b
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
👀