Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(invites): allow implicit team membership to invite to projects on org invites #25773

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

raquelmsmith
Copy link
Member

Problem

If someone isn't explicitly added to a private project, but they have access because they are an admin or owner of the org, they should be able to invite someone to that project via the org invites. But, we were only looking for explicit memberships.

Changes

If there is no explicit membership, get any implicit memberships and use that instead.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

No impact.

How did you test this code?

Wrote a test

@raquelmsmith raquelmsmith requested a review from a team October 23, 2024 19:45
@raquelmsmith raquelmsmith enabled auto-merge (squash) October 23, 2024 19:52
@raquelmsmith raquelmsmith merged commit bb638fe into master Oct 25, 2024
87 checks passed
@raquelmsmith raquelmsmith deleted the fix/org-project-invites-implicit-membership branch October 25, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants