feat(product-assistant): trends generation failover #25769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skoob13
changed the title
skoob13
force-pushed
the
feat/trends-generation-failover
branch
from
7598454 to
680ea43
Compare
…posthog into feat/trends-generation-failover
…generation-failover
…generation-failover
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
…posthog into feat/trends-generation-failover
…generation-failover
Twixes
approved these changes
Oct 30, 2024
frontend/src/scenes/max/maxLogic.ts
Outdated
| @@ -18,6 +29,11 @@ export type ThreadMessage = RootAssistantMessage & { | |||
| status?: MessageStatus | |||
| } | |||
|
|
|||
| const failureMessage: FailureMessage = { | |||
There was a problem hiding this comment.
Nit: Global constants are typically SCREAMING_SNAKE_CASE, e.g. FAILURE_MESSAGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is always a chance that the schema generation step will produce an incorrect schema. Instead of showing an error to the user, we can ask LLMs to fix the error and make a new result based on the validation errors. This step will be repeated multiple times until it reaches a working schema or the recursion limit.
Changes
Add an optional fail-over step for the agent:
Additionally, I added handling of network/parsing errors, so it shows a similar error message.
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
Unit tests + manual testing