feat: watch next and sort different #25701
Conversation
| @@ -44,6 +44,7 @@ export type PlaylistProps<T> = { | |||
| onChangeSections?: (activeKeys: string[]) => void | |||
| 'data-attr'?: string | |||
| activeItemId?: string | |||
| controls?: JSX.Element | null | |||
There was a problem hiding this comment.
playlist is used in multiple places so keeping this row relatively abstract as "controls" rather than just calling it sorting
| @@ -28,7 +32,7 @@ export function RecordingRow({ recording }: RecordingRowProps): JSX.Element { | |||
| return ( | |||
| <ProjectHomePageCompactListItem | |||
| title={asDisplay(recording.person)} | |||
| subtitle={`Recorded ${dayjs(recording.start_time).fromNow()}`} | |||
| subtitle={`activity score: ${recording.mouse_activity_count}`} | |||
There was a problem hiding this comment.
wanted to keep this vague so went with "activity score"
thought it might sound exciting
frontend/src/scenes/session-recordings/filters/OrderingFilters.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/session-recordings/playlist/sessionRecordingsPlaylistLogic.ts
Show resolved
Hide resolved
|
Size Change: -66 B (-0.01%) Total Size: 1.14 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated20 snapshot changes in total. 0 added, 20 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated8 snapshot changes in total. 0 added, 8 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
| @@ -215,7 +215,6 @@ export const FEATURE_FLAGS = { | |||
| INSIGHT_VARIABLES: 'insight_variables', // owner: @Gilbert09 #team-data-warehouse | |||
| WEB_EXPERIMENTS: 'web-experiments', // owner: @team-feature-success | |||
| BIGQUERY_DWH: 'bigquery-dwh', // owner: @Gilbert09 #team-data-warehouse | |||
| REPLAY_DEFAULT_SORT_ORDER_EXPERIMENT: 'replay-order-by-experiment', // owner: #team-replay | |||
There was a problem hiding this comment.
@richard-better i removed the experiment rather than maintain it through the refactor - i think the feedback on my idea showed it was confusing enough that we should try a different tack
There was a problem hiding this comment.
Agreed that this should live within the playlist. Ideally we wouldn't have to introduce a new row to accommodate it but any time I've previously considered this it feels like it would be too hidden behind the cog menu.
Let's go with this for now and review as part of the Replay offsite
frontend/src/scenes/session-recordings/playlist/SessionRecordingsPlaylist.tsx
Outdated
Show resolved
Hide resolved
|
ended up fancying up and moving "Actvity score" to the backend |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated3 snapshot changes in total. 0 added, 3 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
* master: fix(replay-templates): show event selector button, diff mobile filter (#25739) feat(replay): add "what to watch" screen (#25717) fix(events): Fix PostHog property filtering (#25732) fix(api): Apply org/team key scoping more narrowly (#25634) feat(Experiments): UX feedback from private beta of no-code experiments. (#25694) fix: playlist should track current session id (#25730) chore(data-warehouse): Set the stripe version when listing objects (#25729) chore(data-warehouse): Added extra props for hubspot syncs (#25728) revert: perf: Speed up filtering persons pt 2 (#25731) chore(deps): Update posthog-js to 1.174.3 (#25724) perf: Speed up filtering persons pt 2 (#25718) feat(alerts): toggle alert threshold lines (#25700) feat: watch next and sort different (#25701) feat(cdp): add microsoft teams template (#25652)
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Michael Matloka <[email protected]>
home page watch next
folk don't click on the recording links on the home page
let's show them something different and see what they do
order by
we've seen. multiple instances of folk being confused by sorting
both in tickets and when we tried to experiment with it
i have multiple times forgotten that I set the sort order and then been confused and I know how it works
so let's put the sorting control right next to the list