chore: create ClickHouse override tables #25681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
commented
Oct 21, 2024
Comment on lines
+46
to
+75
| KAFKA_ERROR_TRACKING_ISSUE_FINGERPRINT_OVERRIDES_TABLE_SQL = ( | ||
| lambda: ERROR_TRACKING_ISSUE_FINGERPRINT_OVERRIDES_TABLE_BASE_SQL.format( | ||
| table_name="kafka_" + ERROR_TRACKING_ISSUE_FINGERPRINT_OVERRIDES_TABLE, | ||
| cluster=CLICKHOUSE_CLUSTER, | ||
| engine=kafka_engine( | ||
| KAFKA_ERROR_TRACKING_ISSUE_FINGERPRINT, group="clickhouse-error-tracking-issue-fingerprint-overrides" | ||
| ), | ||
| extra_fields="", | ||
| ) | ||
| ) | ||
|
|
||
| ERROR_TRACKING_ISSUE_FINGERPRINT_OVERRIDES_MV_SQL = """ | ||
| CREATE MATERIALIZED VIEW IF NOT EXISTS {table_name}_mv ON CLUSTER '{cluster}' | ||
| TO {database}.{table_name} | ||
| AS SELECT | ||
| team_id, | ||
| fingerprint, | ||
| issue_id, | ||
| is_deleted, | ||
| version, | ||
| _timestamp, | ||
| _offset, | ||
| _partition | ||
| FROM {database}.kafka_{table_name} | ||
| WHERE version > 0 -- only store updated rows, not newly inserted ones | ||
| """.format( | ||
| table_name=ERROR_TRACKING_ISSUE_FINGERPRINT_OVERRIDES_TABLE, | ||
| cluster=CLICKHOUSE_CLUSTER, | ||
| database=CLICKHOUSE_DATABASE, | ||
| ) |
There was a problem hiding this comment.
I couldn't see where either of these two tables were being used for persons distinct id overrides... Is it legacy or necessary part of the table setup in CH? @tkaemming
There was a problem hiding this comment.
These are both necessary — you'll want to only issue read requests against the error_tracking_issue_fingerprint_overrides table and use the Kafka topic (and table) added here to handle writing to the table versus running INSERT/UPDATEs manually. The Kafka table handles the Kafka consumer side, and the materialized view shuttles data from the Kafka table to the data table when there are rows ready to be written.
…posthog into dn-feat/create-overrides-tables
Daesgar
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Related to https://github.com/PostHog/product-internal/pull/662
Changes
We have decided to use the same overrides pattern as person distinct ids. This copies all the work done there to create the necessary tables in ClickHouse