chore: even more taxonomy fangling #25650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pauldambra
commented
Oct 17, 2024
pauldambra
commented
- adds some missed billing properties
- moves a few non dollar properties out since some events are pretty bare without anything shown
- adds another surveys event to the taxonomy so it has nice display in the table
pauldambra
commented
Oct 17, 2024
| @@ -1212,6 +1212,10 @@ export const CORE_FILTER_DEFINITIONS_BY_GROUP = { | |||
| description: 'posthog-js adds these to the page leave event, they are used in web analytics calculations', | |||
| label: 'Previous pageview duration', | |||
| }, | |||
| $surveys_activated: { | |||
There was a problem hiding this comment.
@Phanatic I took a guess at a description here, feel free to correct :)
(at the risk of teaching you to suck eggs... adding event properties here means when we display them we add a logo at the front and show the description in a pop over so folk know they're legit PH properties)
There was a problem hiding this comment.
I have no idea how to eat eggs, I just end up scrambling them :)
Good callout on the event properties! Sounds good to me.
|
Size Change: +109 B (+0.01%) Total Size: 1.14 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.