fix(plugin-server): use UTC now instead of invalid years for timestamp #25635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
force-pushed
the
brett/negative-years
branch
from
084eb29 to
fc7fd46
Compare
bretthoerner
force-pushed
the
brett/negative-years
branch
from
fc7fd46 to
e66f85e
Compare
oliverb123
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Because of weird timestamp mutations in plugin-server, we can emit very negative or far future dates into the CH JSON topic. This trips up things that parse by
YYYY-MM-DD, and can't possibly be what the user is expecting.Changes
Consider
< 0, > 9999years as invalid, so that we fallback to DateTime.utc() like we do for other invalid dates.We could be more restrictive here (
1900-2100?) but as usual, ingestion changes make me nervous and I want to at least fix the specific issue at hand.👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Yes.
How did you test this code?
New unit test.