Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(survey): fix survey set schedule state #25617

Merged
merged 6 commits into from
Oct 16, 2024
Merged

Conversation

jurajmajerik
Copy link
Contributor

@jurajmajerik jurajmajerik commented Oct 16, 2024

Problem

Reported in https://posthoghelp.zendesk.com/agent/tickets/19357

If I set "Repeat on schedule" but don't manipulate the inputs, iteration_count and iteration_frequency_days remain at zero.

Changes

Set these fields to the default 1 and 90 after the schedule is set.

How did you test this code?

👀

@jurajmajerik jurajmajerik requested a review from Phanatic October 16, 2024 08:26
Copy link
Contributor

github-actions bot commented Oct 16, 2024

Size Change: 0 B

Total Size: 1.14 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.14 MB

compressed-size-action

Copy link
Contributor

@Phanatic Phanatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it!

@Phanatic Phanatic enabled auto-merge (squash) October 16, 2024 16:48
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

3 snapshot changes in total. 0 added, 3 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Phanatic Phanatic merged commit 80499c8 into master Oct 16, 2024
93 checks passed
@Phanatic Phanatic deleted the fix-survey-set-schedule branch October 16, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants