chore(bi): Dont allow multiple insight variables with the same code_name #25602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
EDsCODE
approved these changes
Oct 15, 2024
| @@ -97,20 +98,18 @@ export const addVariableLogic = kea<addVariableLogicType>([ | |||
| }, | |||
| ], | |||
| }), | |||
| loaders(({ values, actions }) => ({ | |||
| savedVariable: [ | |||
There was a problem hiding this comment.
Double checking: this variable isn't used
Base automatically changed from
tom/insight-variables-4-dashboard-rollup
to
master
October 17, 2024 08:49
An error occurred while trying to automatically change base from
tom/insight-variables-4-dashboard-rollup
to
master
October 17, 2024 08:49
Gilbert09
force-pushed
the
tom/duplicate-vars
branch
from
5fef8d8 to
d12c127
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
timgl
pushed a commit
that referenced
this pull request
Oct 17, 2024
…ame (#25602) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Backend tests