fix(temporal): Handle SIGTERM correctly on worker cleanup #25505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gilbert09
approved these changes
Oct 10, 2024
tomasfarias
commented
Oct 10, 2024
Comment on lines
+5
to
+12
| cleanup() { | ||
| echo "Stopping worker..." | ||
| if kill -0 "$worker_pid" >/dev/null 2>&1; then | ||
| kill "$worker_pid" | ||
| else | ||
| echo "Worker process is not running." | ||
| fi | ||
| } |
There was a problem hiding this comment.
In case this is cleanup outside this script, do not error.
|
Size Change: +46 B (0%) Total Size: 1.13 MB ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Local devs may have realized that on stopping
./bin/startthe underlyingtemporal-worker-djangoprocess wasn't stopping. This was because we were not properly handlingSIGTERMas a coroutine was not awaited.Changes
./bin/temporal-django-worker👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Manually:
./bin/start/