Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encryption salt key is not any random string #25483

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

pauldambra
Copy link
Member

follow-up to #25479

this continues to be the gift that gives

now plugin server does not start because

{"level":"error","time":1728490554991,"pid":36,"hostname":"f01ec11b8962","error":"Error: Key must be 32-byte long base64url encoded string.\n at Fernet.checkKey (/code/plugin-server/node_modules/.pnpm/[email protected]/node_modules/fernet-nodejs/dist/Fernet.js:28:19)\n

so

  • generate a 32 byte long base64 url encoded string
  • add that if it isn't present when upgrading
  • replace an incorrect key if present when upgrading (because someone may have a broken key from fix: encryption salt keys take 2 #25479

@pauldambra pauldambra requested a review from a team October 9, 2024 16:23
Copy link
Contributor

github-actions bot commented Oct 9, 2024

Size Change: 0 B

Total Size: 1.13 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.13 MB

compressed-size-action

bin/upgrade-hobby Outdated Show resolved Hide resolved
@pauldambra pauldambra merged commit c0368cc into master Oct 9, 2024
87 checks passed
@pauldambra pauldambra deleted the fix/encryption-salt-key branch October 9, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants