Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): add naming convention to url pattern #25438

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

EDsCODE
Copy link
Member

@EDsCODE EDsCODE commented Oct 7, 2024

Problem

  • naming convention isn't applied to saved query name

Changes

  • apply it

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@EDsCODE EDsCODE requested a review from a team October 7, 2024 17:19
@EDsCODE EDsCODE enabled auto-merge (squash) October 7, 2024 20:32
@EDsCODE EDsCODE disabled auto-merge October 7, 2024 20:32
@EDsCODE EDsCODE merged commit 129b279 into master Oct 7, 2024
86 checks passed
@EDsCODE EDsCODE deleted the dw-naming-convention-2 branch October 7, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant