Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alert cron schedules #25350

Merged
merged 6 commits into from
Oct 2, 2024
Merged

fix: alert cron schedules #25350

merged 6 commits into from
Oct 2, 2024

Conversation

anirudhpillai
Copy link
Contributor

@anirudhpillai anirudhpillai commented Oct 2, 2024

Problem

Error in frequency of previous cron tab for alerts

Changes

  • Fixed cron + combined the schedules
  • Fix link in email
  • Show insight derived name as backup if no name specified

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

N/A

How did you test this code?

@anirudhpillai anirudhpillai requested a review from a team October 2, 2024 19:58
@anirudhpillai anirudhpillai enabled auto-merge (squash) October 2, 2024 19:58
@anirudhpillai anirudhpillai disabled auto-merge October 2, 2024 20:06
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Size Change: 0 B

Total Size: 9.21 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 9.21 MB

compressed-size-action

@anirudhpillai anirudhpillai enabled auto-merge (squash) October 2, 2024 20:39
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@anirudhpillai anirudhpillai merged commit 0c874e8 into master Oct 2, 2024
91 of 92 checks passed
@anirudhpillai anirudhpillai deleted the fix/alert-cron branch October 2, 2024 22:10
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (wasn't pushed!)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants