Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove old config value #25286

Closed
wants to merge 14 commits into from
Closed

chore: Remove old config value #25286

wants to merge 14 commits into from

Conversation

benjackwhite
Copy link
Contributor

Problem

We now have dedicated env vars for the different redises. This removes the dangling "capture" one to re-use the same POSTHOG_REDIS_HOST

Changes

  • As on the tin
  • Also moved it into the session replay ingester as thats the only place it is used (dont need to instantiate it everywhere...)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite requested a review from a team September 30, 2024 14:48
@benjackwhite benjackwhite changed the base branch from master to fix/plugin-server-redis October 2, 2024 06:55
Base automatically changed from fix/plugin-server-redis to master October 2, 2024 12:08
An error occurred while trying to automatically change base from fix/plugin-server-redis to master October 2, 2024 12:08
# Conflicts:
#	plugin-server/src/main/ingestion-queues/session-recording/session-recordings-consumer.ts
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@posthog-bot
Copy link
Contributor

This PR was closed due to lack of activity. Feel free to reopen if it's still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants