-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(web-analytics): Add web analytics to onboarding #25239
Conversation
339d1ad
to
482691d
Compare
Size Change: +127 B (0%) Total Size: 9.21 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated6 snapshot changes in total. 0 added, 6 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
7b391fc
to
fa25600
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just two comments
return ( | ||
<> | ||
<h3>Track screen views</h3> | ||
<p>Despite the name, the web analytics dashboard can be used to track screen views in mobile apps, too.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do they need to do anything with this info? Maybe open their app and view some screens to generate some events?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some extra text here, similar to what we say for web
{ | ||
title: 'Capture console logs', | ||
description: `Automatically enable console log capture`, | ||
teamProperty: 'capture_console_log_opt_in', | ||
value: true, | ||
type: 'toggle', | ||
visible: false, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this one isn't necessary for people just getting started with web analytics, so I'd exclude
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
ead27d5
to
08e7843
Compare
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
Web analytics doesn't have an onboarding flow yet
Changes
Add an onboarding flow! I haven't set up the product intro or the billing pages yet, as those changes live in the billing repo.
Not sure which it makes sense to merge first, but this one does work standalone, so potentially this one!
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?