Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web-analytics): Add web analytics to onboarding #25239

Merged
merged 7 commits into from
Oct 3, 2024

Conversation

robbie-c
Copy link
Member

@robbie-c robbie-c commented Sep 26, 2024

Problem

Web analytics doesn't have an onboarding flow yet

Changes

Add an onboarding flow! I haven't set up the product intro or the billing pages yet, as those changes live in the billing repo.

Not sure which it makes sense to merge first, but this one does work standalone, so potentially this one!

Screenshot 2024-10-02 at 13 44 05 Screenshot 2024-10-02 at 13 44 11 Screenshot 2024-10-02 at 13 44 15 Screenshot 2024-10-02 at 13 44 19

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

@robbie-c robbie-c changed the title feature(web-analytics): Add web analytics to onboarding feat(web-analytics): Add web analytics to onboarding Sep 26, 2024
@robbie-c robbie-c force-pushed the feature/add-web-analytics-to-onboarding branch from 339d1ad to 482691d Compare September 26, 2024 18:26
Copy link
Contributor

github-actions bot commented Sep 26, 2024

Size Change: +127 B (0%)

Total Size: 9.21 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 9.21 MB +127 B (0%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@robbie-c robbie-c force-pushed the feature/add-web-analytics-to-onboarding branch from 7b391fc to fa25600 Compare October 2, 2024 12:27
@robbie-c robbie-c marked this pull request as ready for review October 2, 2024 12:34
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 2)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just two comments

return (
<>
<h3>Track screen views</h3>
<p>Despite the name, the web analytics dashboard can be used to track screen views in mobile apps, too.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do they need to do anything with this info? Maybe open their app and view some screens to generate some events?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some extra text here, similar to what we say for web

Comment on lines 231 to 238
{
title: 'Capture console logs',
description: `Automatically enable console log capture`,
teamProperty: 'capture_console_log_opt_in',
value: true,
type: 'toggle',
visible: false,
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this one isn't necessary for people just getting started with web analytics, so I'd exclude

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@robbie-c robbie-c force-pushed the feature/add-web-analytics-to-onboarding branch from ead27d5 to 08e7843 Compare October 3, 2024 07:35
@robbie-c robbie-c enabled auto-merge (squash) October 3, 2024 07:36
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@robbie-c robbie-c merged commit a561868 into master Oct 3, 2024
92 checks passed
@robbie-c robbie-c deleted the feature/add-web-analytics-to-onboarding branch October 3, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants