fix(projects): Fix project creation when access_control set
#24988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Brought up in ZEN-18151 (CC @bretthoerner @raquelmsmith):
Since Thursday, project creation has been erroring when
access_controlwas specified. This was not an issue in the app, which does not set this param on project creation, but a customer using the API this way experienced disruption.Sentry issue POSTHOG-1KFT.
Changes
The bug appeared after a refactor in #24154 that simplified one path a bit too much. The problem is that we didn't have a test for this path of project creation.
This fixes the bug and adds a few tests to better cover project creation (
access_controlandprimary_dashboardwere lacking coverage).