feat(propdefs): add filtering to allow for gradual rollout #24820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverb123
force-pushed
the
olly_propdefs_rollout_prep
branch
from
2d2db2d to
318d1da
Compare
oliverb123
requested review from
bretthoerner and
benjackwhite
and removed request for
bretthoerner
|
Size Change: +50 B (0%) Total Size: 1.12 MB ℹ️ View Unchanged
|
bretthoerner
approved these changes
Sep 5, 2024
| // that includes automatic group creation, which we want to do even if we're skipping the | ||
| // rest of the definition updates, so we run this and tell it to skip, rather than skipping | ||
| // it outright. | ||
| promises.push(this.syncPropertyDefinitions(team, event, properties, shouldSkip)) |
benjackwhite
approved these changes
Sep 6, 2024
| @@ -74,6 +78,7 @@ export class PropertyDefinitionsManager { | |||
| eventPropertiesCache: LRU<string, Set<string>> // Map<JSON.stringify([TeamId, Event], Set<Property>> | |||
| eventLastSeenCache: LRU<string, number> // key: JSON.stringify([team_id, event]); value: parseInt(YYYYMMDD) | |||
| propertyDefinitionsCache: PropertyDefinitionsCache | |||
| teamIdsToSkip: Set<number> = new Set() | |||
There was a problem hiding this comment.
A value matcher would be slightly nicer so we can use "*" to rollout for all teams whilst still being able to roll back easily but not blocking
There was a problem hiding this comment.
Would rather delete the code once we make the switch - should be high confidence at that point, and the plugin server is enough of a mess already without also having all this stuff that's never used in prod but exists because it was once
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.