feat: Switch batch exports logging to async #24819
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Had good results with moving file writing to a thread in #24792. Inspired by that, I reviewed where we could have more blocking code, and that lead me to our logging (and also to #24804).
Structlog provides async methods that use a thread pool for logging. Our processor chain is not that complex that should be blocking for too long, but occasional timeouts tell us that we still have some blocking code. As little as it may be, Temporal workflows work best when nothing is blocking, so, let's also not block when logging. Our workflows are entirely bound by IO, so the extra computational overhead is not significant for our use case.
Changes
a
).👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Nothing really changed, functionality-wise. So, existing tests should cover this PR.