Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(frontend): Kill @ant-design/icons #24817

Merged
merged 5 commits into from
Sep 6, 2024
Merged

chore(frontend): Kill @ant-design/icons #24817

merged 5 commits into from
Sep 6, 2024

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Sep 5, 2024

Problem

We are still using Ant Design's icons in a few places. Noticed because of unexpected snapshot changes on #24377.

Changes

Ants gone.

@Twixes Twixes requested a review from a team September 5, 2024 15:39
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

6 snapshot changes in total. 0 added, 6 modified, 0 deleted:

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

Size Change: -20 kB (-1.79%)

Total Size: 1.1 MB

Filename Size Change
frontend/dist/toolbar.js 1.1 MB -20 kB (-1.79%)

compressed-size-action

@Twixes Twixes merged commit 1304a95 into master Sep 6, 2024
93 checks passed
@Twixes Twixes deleted the rm-ant-icons branch September 6, 2024 15:26
timgl pushed a commit that referenced this pull request Sep 10, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants