Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data-warehouse): Ensure last synced at is always updated #24811

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • If a sync occurs and no data is returned (e.g. in an incremental sync), then the schemas last_synced_at time isn't updated, making it look like it wasn't actually ran

Changes

Ensure the datetime is always updated when we have a successful sync

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Updated end to end tests to include this

@Gilbert09 Gilbert09 requested a review from a team September 5, 2024 13:01
@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week. If you want to permanentely keep it open, use the waiting label.

@Gilbert09 Gilbert09 merged commit e26055b into master Sep 13, 2024
86 checks passed
@Gilbert09 Gilbert09 deleted the tom/lst-synced-at branch September 13, 2024 11:55
Copy link

sentry-io bot commented Sep 18, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ OperationalError: connection failed: connection to server at "172.20.49.244", port 6543 failed: server closed the c... posthog.warehouse.models.external_data_schema i... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants