fix(dashboards): Make sure loading dashboard items does not POST /query/
#24808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +44 B (0%) Total Size: 1.12 MB ℹ️ View Unchanged
|
Twixes
force-pushed
the
shared-dashboard-poll-only
branch
from
db59695 to
66ed13a
Compare
Twixes
commented
Sep 5, 2024
| @@ -29,7 +36,6 @@ export function queryExportContext<N extends DataNode>( | |||
| const SYNC_ONLY_QUERY_KINDS = [ | |||
| 'HogQuery', | |||
| 'HogQLMetadata', | |||
| 'EventsQuery', | |||
There was a problem hiding this comment.
Was surprised that EventsQuery (aka activity view/data table) is sync-only! Please QA that async is good here
There was a problem hiding this comment.
Everything works well. I tested various nodes of EventsQuery.
skoob13
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Shared dashboard items without previously cached results have not been loading correctly since we switched to async loading on shared dashboards. See this report: ZEN-17258.
We have a test which should have caught this long ago, but for some reason it was basically disabled in #21187.
Changes
This re-enables the test (it fails as expected on master), and adds a
pollOnlyflag toexecuteQuery, which allows us to use all the existing loading logic, the only change being that when we know the in-progress query ID (as is the case with GETting loading saved insights/dashboards), we don't POST /query/ needlessly – we only poll that known query ID.How did you test this code?
E2E test.