Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed some logging #24788

Merged
merged 7 commits into from
Sep 5, 2024
Merged

chore: Removed some logging #24788

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
cfcc732
Fixed serialization to not include the hog function
benjackwhite Sep 4, 2024
fa8c489
Fix up parallel sending
benjackwhite Sep 4, 2024
a06fefe
Fixes
benjackwhite Sep 4, 2024
60f36b9
Fixes
benjackwhite Sep 4, 2024
456de20
Fix
benjackwhite Sep 4, 2024
97bb0d2
Fixes
benjackwhite Sep 4, 2024
224e2f6
Merge branch 'master' into fix/logging
benjackwhite Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions plugin-server/src/cdp/cdp-consumers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,8 +237,6 @@ abstract class CdpConsumerBase {
await runInstrumentedFunction({
statsKey: `cdpConsumer.handleEachBatch.produceResults`,
func: async () => {
console.log('Processing invocations results', results.length)

await Promise.all(
results.map(async (result) => {
// Tricky: We want to pull all the logs out as we don't want them to be passed around to any subsequent functions
Expand Down Expand Up @@ -635,12 +633,6 @@ export class CdpFunctionCallbackConsumer extends CdpConsumerBase {
})
)

invocations.forEach((item) => {
if (!item.hogFunction?.id) {
console.error('No hog function id', item)
}
})

return invocations
},
})
Expand Down
Loading