Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdp): Fixed serialization to not include the hog function #24785

Merged
merged 5 commits into from
Sep 4, 2024

Conversation

benjackwhite
Copy link
Contributor

Problem

The fetch serializer includeed the hog function instead of just the ID.

Changes

  • Change it to include just the ID with a shared function
  • Deserialization already supports both options

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@benjackwhite benjackwhite requested a review from a team September 4, 2024 14:48
@benjackwhite benjackwhite enabled auto-merge (squash) September 4, 2024 15:27
@benjackwhite benjackwhite merged commit 04ef403 into master Sep 4, 2024
86 checks passed
@benjackwhite benjackwhite deleted the fix/cdp-serialization branch September 4, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants