Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data-warehouse): Exclude rows missing the cursor path of incremental value #24782

Merged
merged 3 commits into from
Sep 4, 2024
Merged

fix(data-warehouse): Exclude rows missing the cursor path of incremental value #24782

merged 3 commits into from
Sep 4, 2024

Conversation

Gilbert09
Copy link
Member

Problem

Changes

  • If an incremental cursor value is missing, then ignore that row

Does this work well for both Cloud and self-hosted?

Yes

How did you test this code?

Added tests

@Gilbert09 Gilbert09 requested a review from a team September 4, 2024 13:41
Gilbert09
Gilbert09 commented Sep 4, 2024
View reviewed changes
posthog/warehouse/types.py
from typing import TypedDict


class IncrementalFieldType(Enum):
class IncrementalFieldType(StrEnum):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was the real change here! We weren't doing proper comparisons on IncrementalFieldType without it

@Gilbert09 Gilbert09 enabled auto-merge (squash) September 4, 2024 15:26
@Gilbert09 Gilbert09 merged commit 8b3aeb2 into master Sep 4, 2024
86 checks passed
@Gilbert09 Gilbert09 deleted the tom/sql-missing-cursor branch September 4, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EDsCODE EDsCODE EDsCODE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gilbert09 @EDsCODE