Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Added error messages on components other than table #24779

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Gilbert09
Copy link
Member

Problem

  • SQL errors only show on the Table visualization type

Changes

Show them on all types!

image

Does this work well for both Cloud and self-hosted?

Yup

How did you test this code?

See screenshot 👀

@Gilbert09 Gilbert09 requested a review from a team September 4, 2024 12:42
Copy link
Contributor

github-actions bot commented Sep 4, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@Gilbert09 Gilbert09 merged commit a5f1deb into master Sep 4, 2024
94 checks passed
@Gilbert09 Gilbert09 deleted the tom/bi-error-message branch September 4, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants