feat(onboarding-templates): create custom variable selector panel #24770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raquelmsmith
commented
Sep 3, 2024
Comment on lines
+57
to
+77
| onChange={(v) => { | ||
| if (v) { | ||
| setCustomEventName(v) | ||
| setVariable(variable.name, { | ||
| events: [{ id: v, math: 'dau', type: 'events' }], | ||
| }) | ||
| } else { | ||
| setCustomEventName(null) | ||
| resetVariable(variable.id) | ||
| } | ||
| }} | ||
| onBlur={() => { | ||
| if (customEventName) { | ||
| setVariable(variable.name, { | ||
| events: [{ id: customEventName, math: 'dau', type: 'events' }], | ||
| }) | ||
| } else { | ||
| resetVariable(variable.id) | ||
| setShowCustomEventField(false) | ||
| } | ||
| }} |
There was a problem hiding this comment.
I feel like this is pretty poor handling...
|
Size Change: +1.69 kB (+0.15%) Total Size: 1.12 MB
|
raquelmsmith
commented
Sep 4, 2024
| status="alt" | ||
| onClick={() => { | ||
| setShowCustomEventField(false) | ||
| setVariable(variable.name, { events: [FALLBACK_EVENT] }) |
There was a problem hiding this comment.
in a follow-up PR this will actually get the action from the toolbar in the iframe, but for now it just sets fallback event info
zlwaterfield
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
Overall, it looks good. I haven't gotten this fully up locally because my ingestion isn't working, so I need to wipe my local inf. Then, I will try again and add more feedback. But I don't want to block you in the meantime.
I have added a few comments about skipping and some of the chosen copy.
frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateConfigureStep.tsx
Outdated
Show resolved
Hide resolved
frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateVariables.tsx
Show resolved
Hide resolved
frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateVariables.tsx
Show resolved
Hide resolved
frontend/src/scenes/onboarding/productAnalyticsSteps/DashboardTemplateVariables.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
For #23065
We want the template variable selector process to be as simple as possible for new users - they can always add more complex filters and stuff later. At this point they need two options - select from site, or define a custom event name.
Changes
Screen.Recording.2024-09-03.at.8.59.13.PM.mov
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Clicked around a bunch to handle all the edge cases but LMK if you find any :)