feat: home tab of replay doesn't need to be called recent #24763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daibhin
approved these changes
Sep 3, 2024
daibhin
reviewed
Sep 3, 2024
frontend/src/scenes/scenes.ts
Outdated
| @@ -428,6 +428,7 @@ export const redirects: Record< | |||
| return urls.replay() | |||
| }, | |||
| '/replay': urls.replay(), | |||
| '/replay/recent': urls.replay(), | |||
There was a problem hiding this comment.
I'm assuming this does the redirect and maintains any query params?
There was a problem hiding this comment.
obviously I'd tested that 🙈
|
Size Change: +36 B (0%) Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
pauldambra
commented
Sep 3, 2024
| @@ -98,8 +98,11 @@ export const urls = { | |||
| savedInsights: (tab?: string): string => `/insights${tab ? `?tab=${tab}` : ''}`, | |||
| webAnalytics: (): string => `/web`, | |||
|
|
|||
| replay: (tab?: ReplayTabs, filters?: Partial<RecordingUniversalFilters>): string => | |||
| combineUrl(tab ? `/replay/${tab}` : '/replay/recent', filters ? { filters } : {}).url, | |||
| replay: (tab?: ReplayTabs, filters?: Partial<RecordingUniversalFilters>, sessionRecordingId?: string): string => | |||
There was a problem hiding this comment.
we support sessionRecordingId as a query param... but it wasn't in this contract
MarconLP
pushed a commit
that referenced
this pull request
Sep 6, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see: https://posthog.slack.com/archives/C03PB072FMJ/p1725370913316809?thread_ts=1725267564.281409&cid=C03PB072FMJ
As we add more ordering to the landing page of replay it doesn't make sense to call it "recent recordings"
this
/replay/home/replace/recent