Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): Add icon for group property filters #24762

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Sep 3, 2024

Problem

Noticed that we have icons for event and person property filters, but group ones are unmarked (came up when debugging this groups-related report).

Changes

Went for IconBuilding:

Screenshot 2024-09-03 at 16 43 54

@Twixes Twixes requested a review from a team September 3, 2024 14:55
Copy link
Contributor

github-actions bot commented Sep 3, 2024

Size Change: 0 B

Total Size: 1.11 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.11 MB

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@Twixes Twixes merged commit dccb835 into master Sep 4, 2024
93 checks passed
@Twixes Twixes deleted the group-filter-icon branch September 4, 2024 10:04
MarconLP pushed a commit that referenced this pull request Sep 6, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants