-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(data-warehouse): Updated billing limits to work per sync #24752
Conversation
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
frontend/src/scenes/data-warehouse/settings/DataWarehouseManagedSourcesTable.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had some open question regarding whether we should instead have a separate status for billing limits reached instead of re-using cancelled.
But overall I don't think it would be a blocker.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Problem
In my opinion, we had a subpar experience for when users hit data warehouse billing limits. We're running a celery task every 20 mins to check whether a team has hit its limits and then "Pause" and "Cancel" existing jobs/schemas. Why was this bad?
Changes
Does this work well for both Cloud and self-hosted?
Yep
How did you test this code?
Added a unit test to ensure no rows get synced when limits are hit