feat(cdp): Use cyclotron part 2 #24746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # plugin-server/tests/cdp/cdp-api.test.ts # plugin-server/tests/cdp/cdp-processed-events-consumer.test.ts # plugin-server/tests/cdp/hog-executor.test.ts
# Conflicts: # plugin-server/src/cdp/hog-executor.ts
# Conflicts: # plugin-server/src/cdp/cdp-consumers.ts # plugin-server/src/main/pluginsServer.ts
# Conflicts: # plugin-server/src/cdp/cdp-consumers.ts # plugin-server/src/main/pluginsServer.ts
benjackwhite
requested review from
oliverb123,
bretthoerner and
mariusandra
and removed request for
oliverb123 and
bretthoerner
# Conflicts: # plugin-server/src/cdp/cdp-consumers.ts
mariusandra
requested changes
Sep 9, 2024
mariusandra
approved these changes
Sep 9, 2024
benjackwhite
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit 7fd0fbb.
timgl
pushed a commit
that referenced
this pull request
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The first PR refactored the code to make it easier to enqueue and read from Cyclotron instead of Kafka. This implements it
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?