Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): add loops hog function #24713

Merged
merged 6 commits into from
Sep 5, 2024
Merged

feat(cdp): add loops hog function #24713

merged 6 commits into from
Sep 5, 2024

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Aug 30, 2024

Changes

  • add loops hog function
  • add tests

Changes compared to the old plugin:

  • we'll always send person properties compared to only on $identify and $set events.

How did you test this code?

compare the webhook payload to the old loops plugin

@MarconLP MarconLP changed the title add loops hog function feat: add loops hog function Aug 30, 2024
@MarconLP MarconLP changed the title feat: add loops hog function feat(cdp): add loops hog function Aug 30, 2024
Copy link
Contributor

github-actions bot commented Aug 30, 2024

Size Change: 0 B

Total Size: 1.12 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.12 MB

compressed-size-action

@MarconLP MarconLP requested a review from benjackwhite August 30, 2024 15:00
@MarconLP MarconLP marked this pull request as ready for review August 30, 2024 15:01
@MarconLP MarconLP mentioned this pull request Aug 30, 2024
61 tasks
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MarconLP MarconLP enabled auto-merge (squash) September 5, 2024 12:01
@MarconLP MarconLP merged commit 58a96cd into master Sep 5, 2024
93 checks passed
@MarconLP MarconLP deleted the loops-hog-template branch September 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants