Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make avg response times more visible in support form #24588

Merged
merged 8 commits into from
Aug 27, 2024

Conversation

slshults
Copy link
Contributor

Moving list of average response times from top of sidebar to new location below submit/cancel buttons for better visibility, based on this conversation.

List of avg response times now appear very near where the Email an engineer button was. Makes it hard to miss:

CleanShot 2024-08-26 at 15 52 39

Does this work well for both Cloud and self-hosted?

No, won't be seen on self-hosted.

How did you test this code?

In codespaces (gif above is from my test. Also submitted a test ticket, confirmed it arrived in Zendesk.)

`Submit` button for better visibility.
@slshults slshults changed the title Make avg response times more visible in support form chore: Make avg response times more visible in support form Aug 26, 2024
Copy link
Contributor

github-actions bot commented Aug 26, 2024

Size Change: +251 B (+0.02%)

Total Size: 1.08 MB

ℹ️ View Unchanged
Filename Size Change
frontend/dist/toolbar.js 1.08 MB +251 B (+0.02%)

compressed-size-action

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

Copy link
Member

@raquelmsmith raquelmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Approving, assuming the top padding gets added. Make sure to check it out visually to make sure it looks alright.

@slshults slshults requested a review from raquelmsmith August 27, 2024 00:43
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@slshults slshults enabled auto-merge (squash) August 27, 2024 19:12
@slshults slshults requested a review from raquelmsmith August 27, 2024 19:15
@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@posthog-bot
Copy link
Contributor

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

  • chromium: 0 added, 2 modified, 0 deleted (diff for shard 1)
  • webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

@slshults slshults merged commit f4497a7 into master Aug 27, 2024
93 checks passed
@slshults slshults deleted the slshults-move-avg-response-time branch August 27, 2024 20:15
pauldambra pushed a commit that referenced this pull request Aug 29, 2024
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Raquel Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants