feat(hogvm): serialize the stack between async operations #24574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know why these "Django tests – Core" tests are not running. However this PR doesn't touch the django backend and everything else is green. I'd be happy to force-merge if someone reviews. |
bretthoerner
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We can't JSON.stringify Maps.
Changes
Treat the
stackas normal JS objects outside of Hog.How did you test this code?
Added a test.
Tried to test E2E locally, but can't get plugin server running :'(I mocked out allcyclotroncode in the plugin server and this did work well E2E with whatever was remaining:Ran the flow locally. Before headers2 was empty, now it's not.