feat(cyclotron): Change dead-letter strategy, adopt in fetch and janitor #24569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bretthoerner
approved these changes
Aug 26, 2024
Co-authored-by: Brett Hoerner <[email protected]>
|
Gonna merge this, rebase your PR and fix it up, then try to merge that too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also yanked the sqlx dependency out of the janitors by making it work more like workers and managers... trying to keep "this is all running atop a DB" an implementation detail thats behind an API boundary for now (although ofc configs leak it).