Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdp): rudderstack hog function #24556

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

MarconLP
Copy link
Member

@MarconLP MarconLP commented Aug 23, 2024

Changes

  • add rudderstack hog function
  • add this code
  • add tests

Changes compared to the old plugin:

  • $elements property isn't being sent anymore (didn't work anyways) (link)
  • Properties will be sent even if something is null

Example:
2024-08-23 at 20 05 23

How did you test this code?

compare the webhook payload to the old rudderstack plugin

@MarconLP MarconLP changed the title rudderstack hog function feat(cdp) rudderstack hog function Aug 23, 2024
@MarconLP MarconLP changed the title feat(cdp) rudderstack hog function feat(cdp): rudderstack hog function Aug 23, 2024
@MarconLP MarconLP requested a review from benjackwhite August 23, 2024 18:36
@MarconLP MarconLP marked this pull request as ready for review August 23, 2024 18:36
@MarconLP MarconLP mentioned this pull request Aug 23, 2024
61 tasks
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far looking good. Once the tests are there ping me for a review again and we can get this shipped 🙌

posthog/cdp/templates/rudderstack/template_rudderstack.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Size Change: +37 kB (+3.44%)

Total Size: 1.11 MB

Filename Size Change
frontend/dist/toolbar.js 1.11 MB +37 kB (+3.44%)

compressed-size-action

@MarconLP MarconLP requested a review from benjackwhite August 29, 2024 15:57
Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MarconLP MarconLP merged commit f32e23f into master Sep 5, 2024
93 checks passed
@MarconLP MarconLP deleted the rudderstack-hog-function-template branch September 5, 2024 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants