Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): Remove responses from all actions #24548

Merged
merged 3 commits into from
Aug 23, 2024
Merged

fix(docs): Remove responses from all actions #24548

merged 3 commits into from
Aug 23, 2024

Conversation

timgl
Copy link
Collaborator

@timgl timgl commented Aug 23, 2024

Problem

Most actions don't return the same response as the top level API endpoints, but according to our docs they do (example).

internal slack thread

Changes

Wrap the @actions decorator in an extend_schema decorator that removes the response.

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link
Contributor

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oooh nice

@timgl timgl merged commit b0b4a69 into master Aug 23, 2024
86 checks passed
@timgl timgl deleted the remove-responses branch August 23, 2024 13:06
Copy link

sentry-io bot commented Aug 23, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Team.DoesNotExist: Team matching query does not exist. /api/projects/{parent_lookup_project_id}/activi... View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout /api/feature_flag/local_evaluation/ View Issue
  • ‼️ OperationalError: consuming input failed: query_wait_timeout /api/feature_flag/local_evaluation/ View Issue
  • ‼️ OperationalError: connection failed: connection to server at "172.20.74.44", port 6543 failed: FATAL: client_login... /api/feature_flag/local_evaluation/ View Issue
  • ‼️ OperationalError: connection timeout expired /api/feature_flag/local_evaluation/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants