fix(insights): use exclude_none flag for cleaner queries #24546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @thmsobrmlr! 👋 |
skoob13
requested changes
Aug 23, 2024
posthog/models/insight.py
Outdated
| return {"kind": "InsightVizNode", "source": filter_to_query(self.filters).model_dump(), "full": True} | ||
| return { | ||
| "kind": "InsightVizNode", | ||
| "source": filter_to_query(self.filters).model_dump(exclude_unset=True, exclude_none=True), |
There was a problem hiding this comment.
I've noticed that the exclude_unset also removes the kind property and other set-by-default properties from the source. For example, this query:
{'full': True, 'kind': 'DataTableNode', 'source': {'kind': 'ActorsQuery', 'properties': [{'key': 'id', 'type': 'cohort', 'value': 4669}]}}Becomes:
{'full': True, 'kind': 'DataTableNode', 'source': {'properties': [{'key': 'id', 'value': 4669}]}}I think we want to keep those properties.
There was a problem hiding this comment.
Ah yeah definitely. Don't know why I commited with this setting. Good catch!
skoob13
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?