Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Attribute cache warming queries #24543

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

webjunkie
Copy link
Contributor

Problem

Slight facepalm moment: Need to pass the insight and dashboard ids so the queries can be attributed properly and the cache target age is adjusted in redis 🤦🏻

Changes

Pass ids.

Copy link

sentry-io bot commented Aug 23, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/caching/warming.py

Function Unhandled Issue
warm_insight_cache_task Insight.DoesNotExist: Insight matching query does not exist. posthog.caching.warming.warm_insigh...
Event Count: 116
warm_insight_cache_task Dashboard.DoesNotExist: Dashboard matching query does not exist. posthog.caching.warming.warm_in...
Event Count: 3
schedule_warming_for_teams_task EstimatedQueryExecutionTimeTooLong: Estimated query execution time (38061.87391053082 seconds) is too long. Try reducing its scope by... ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@webjunkie webjunkie requested a review from a team August 23, 2024 08:36
@webjunkie webjunkie merged commit c568328 into master Aug 23, 2024
87 checks passed
@webjunkie webjunkie deleted the fix/query-cache-warming-attribution branch August 23, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants