fix: Fix column order difference between creation and migration in raw_sessions #24505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbie-c
force-pushed
the
fix/fix-column-order-and-backfill-script
branch
from
fd74671 to
fdbb3fd
Compare
robbie-c
force-pushed
the
fix/fix-column-order-and-backfill-script
branch
from
fdbb3fd to
21b7ef4
Compare
robbie-c
commented
Aug 21, 2024
| @@ -7,6 +7,7 @@ | |||
| ADD COLUMN IF NOT EXISTS | |||
| page_screen_autocapture_uniq_up_to | |||
| AggregateFunction(uniqUpTo(1), Nullable(UUID)) | |||
| AFTER maybe_has_session_replay | |||
There was a problem hiding this comment.
This line should have been included before
Daesgar
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out from #24475 as just the most essential changes
Problem
The columns as created by the migrations were in a different order to the creation SQL, which broke the backfill script. This was my bad - I included them in the middle of the SQL but didn't include an AFTER expression in the migration.
Changes
These migrations have already been run on the EU and US cloud instances, so let's treat the order currently live as fixed. This changes the code to match what is running in prod.
It also adds a test to ensure the backfill SQL can run successfully
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Added a test